Re: Comment fix of config_default.pl

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: michael(at)paquier(dot)xyz
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Comment fix of config_default.pl
Date: 2019-07-12 06:34:11
Message-ID: 20190712.153411.124629535.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thanks.

At Fri, 12 Jul 2019 13:01:13 +0900, Michael Paquier <michael(at)paquier(dot)xyz> wrote in <20190712040113(dot)GD2149(at)paquier(dot)xyz>
> On Fri, Jul 12, 2019 at 12:15:29PM +0900, Kyotaro Horiguchi wrote:
> > In src/tools/msvc/config_default.pl, parameter "perl" requires a
> > path string, not a bool differently from that of configure
> > script. --with-python has the same characteristics and the
> > comment is suggesting that.
> >
> > We need to fix --with-perl and --with-uuid the same way.
> >
> > + uuid => undef, # --with-ossp-uuid=<path>
>
> --with-ossp-uuid is an obsolete spelling. Wouldn't it be better to
> replace it with --with-uuid=<path>? That would be a bit inconsistent

Oops! Right. My eyes slipped over the difference..

> with configure which can only take a set of hardcoded names, still
> there is little point in keeping an option which would get removed
> sooner than later?

Agreed. Attached the fixed version.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
config_default_comment_fix_v2.patch text/x-patch 1.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2019-07-12 06:44:58 Check-out mutable functions in check constraints
Previous Message Igal Sapir 2019-07-12 06:23:11 Re: Unknown type name bool