| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | David Fetter <david(at)fetter(dot)org> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH v4] Add \warn to psql |
| Date: | 2019-07-09 01:29:17 |
| Message-ID: | 20190709012917.7ymhvjyivaff3rwh@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 5, 2019 at 11:29:03PM +0200, David Fetter wrote:
> > While I was fooling with it I noticed that the existing code for -n
> > is buggy. The documentation says clearly that only the first
> > argument is a candidate to be -n:
> >
> > If the first argument is an unquoted <literal>-n</literal> the trailing
> > newline is not written.
> >
> > but the actual implementation allows any argument to be recognized as
> > -n:
> >
> > regression=# \echo this -n should not be -n like this
> > this should not be like thisregression=#
> >
> > I fixed that, but I'm wondering if we should back-patch that fix
> > or leave the back branches alone.
>
> +0.5 for back-patching.
Uh, if this was done in a major release I am thinking we have to mention
this as an incompatibility, which means we should probably not backpatch
it.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-07-09 01:31:05 | Re: PGOPTIONS="-fh" make check gets stuck since Postgres 11 |
| Previous Message | Peter Geoghegan | 2019-07-09 00:33:01 | Re: Improve search for missing parent downlinks in amcheck |