Re: Cleanup/remove/update references to OID column

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Daniel Verite <daniel(at)manitou-mail(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Cleanup/remove/update references to OID column
Date: 2019-07-01 15:59:32
Message-ID: 20190701155932.GA22866@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I'm resending this patch, which still seems to be needed.

Also, should this be removed ? Or at leat remove the parenthesized text, since
non-system tables no longer have OIDs: "(use to avoid output on system tables)"

https://www.postgresql.org/docs/devel/runtime-config-developer.html
trace_lock_oidmin (integer)

And maybe this (?)
trace_lock_table (integer)

On Wed, May 08, 2019 at 02:05:57PM -0500, Justin Pryzby wrote:
> I found what appears to be a dangling reference to old "hidden" OID behavior.
>
> Justin

> From 1c6712c0ade949648dbc415dfd7ea80312360ef7 Mon Sep 17 00:00:00 2001
> From: Justin Pryzby <pryzbyj(at)telsasoft(dot)com>
> Date: Wed, 8 May 2019 13:57:12 -0500
> Subject: [PATCH v1] Cleanup/remove/update references to OID column...
>
> ..in wake of 578b229718e8f.
>
> See also
> 93507e67c9ca54026019ebec3026de35d30370f9
> 1464755fc490a9911214817fe83077a3689250ab
> f6b39171f3d65155b9390c2c69bc5b3469f923a8
>
> Author: Justin Pryzby <justin(at)telsasoft(dot)com>
> ---
> doc/src/sgml/catalogs.sgml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml
> index d544e60..0f9c6f2 100644
> --- a/doc/src/sgml/catalogs.sgml
> +++ b/doc/src/sgml/catalogs.sgml
> @@ -610,7 +610,7 @@
> <entry><structfield>oid</structfield></entry>
> <entry><type>oid</type></entry>
> <entry></entry>
> - <entry>Row identifier (hidden attribute; must be explicitly selected)</entry>
> + <entry>Row identifier</entry>
> </row>
>
> <row>
> --
> 2.7.4
>

--
Justin Pryzby
System Administrator
Telsasoft
+1-952-707-8581

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-07-01 16:13:11 Re: Cleanup/remove/update references to OID column
Previous Message Alvaro Herrera 2019-07-01 15:57:01 Re: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown)