| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Daniel Verite <daniel(at)manitou-mail(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Cleanup/remove/update references to OID column |
| Date: | 2019-07-01 16:13:11 |
| Message-ID: | 14686.1561997591@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Justin Pryzby <pryzby(at)telsasoft(dot)com> writes:
> I'm resending this patch, which still seems to be needed.
Yeah, clearly one copy of that text got missed out. Pushed that.
> Also, should this be removed ? Or at leat remove the parenthesized text, since
> non-system tables no longer have OIDs: "(use to avoid output on system tables)"
No, I think that's still fine as-is. Tables still have OIDs, they
just don't *contain* magic OID columns.
> And maybe this (?)
> trace_lock_table (integer)
Hm, the description of that isn't English, at least:
gettext_noop("Sets the OID of the table with unconditionally lock tracing."),
I'm not entirely sure about the point of tracing locks on just one
table, which seems to be what this is for.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2019-07-01 16:14:20 | Re: Add parallelism and glibc dependent only options to reindexdb |
| Previous Message | Justin Pryzby | 2019-07-01 15:59:32 | Re: Cleanup/remove/update references to OID column |