From: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
---|---|
To: | thomas(dot)munro(at)gmail(dot)com |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Tab completion for CREATE TYPE |
Date: | 2019-05-14 11:13:24 |
Message-ID: | 20190514.201324.19005271.horiguchi.kyotaro@lab.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
At Tue, 14 May 2019 18:58:14 +1200, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote in <CA+hUKG+ojKTKw=aG6QU=VmPMc8Sq7nM4Ah7fk1e+g1YngCVNmg(at)mail(dot)gmail(dot)com>
> On Tue, May 14, 2019 at 6:18 PM Kyotaro HORIGUCHI
> <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> > I played with this a bit and found that "... (attr=[tab]" (no
> > space between "r" and "=") complets with '='. Isn't it annoying?
> >
> > Only "UPDATE hoge SET a=[tab]" behaves the same way among
> > existing completions.
>
> Hmm. True. Here's one way to fix that.
Thanks. That's what was in my mind.
Some definition item names are induced from some current states
(e.g. "CREATE TYPE name AS RANGE (" => "SUBTYPE = ") but I think
it's too much.
COLLATE is not suggested with possible collations but I think
suggesting it is not so useful.
PASSEDBYVALUE is suggested with '=', which is different from
documented syntax but I don't think that's not such a problem for
those who spell this command out.
# By the way, collatable and preferred are boolean which behaves
# the same way with passedbyvalue. Is there any intention in the
# difference in the documentation?
The completion lists contain all possible words correctly (I
think "analyse" is an implicit synonym.).
As the result, I find it perfect.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2019-05-14 11:29:01 | Table AM callback table_complete_speculative()'s succeeded argument is reversed |
Previous Message | Heikki Linnakangas | 2019-05-14 10:38:01 | Re: Failure in contrib test _int on loach |