Re: pgsql: Fix union for pgstat message types

From: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix union for pgstat message types
Date: 2019-05-04 15:48:02
Message-ID: 20190504154802.q4ezzpkbryw7cngq@development
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Wed, May 01, 2019 at 10:34:52AM +0000, Magnus Hagander wrote:
>Fix union for pgstat message types
>
>The message type for temp files and for checksum failures were missing
>from the union. Due to the coding style used there was no compiler error
>when this happend. So change the code to actively use the union thereby
>producing a compiler error if the same mistake happens again, suggested
>by Tom Lane.
>

Should the tempfile bit be backported? That message was added in 9.2.

regards

--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-05-04 15:54:12 Re: pgsql: Fix union for pgstat message types
Previous Message Peter Eisentraut 2019-05-04 14:58:01 pgsql: pg_dump: Fix newline in error message