| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Switch TAP tests of pg_rewind to use a role with minimal permiss |
| Date: | 2019-04-13 15:12:25 |
| Message-ID: | 20190413151225.GA4307@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 2019-Apr-13, Michael Paquier wrote:
> On Fri, Apr 12, 2019 at 11:54:48PM -0400, Tom Lane wrote:
> > Hm. Seems like that test case could also use some work so that it's
> > more obvious when it has connection problems.
>
> For the problem reported, the deal is that we need to add in
> pg_indent.conf a mapping to the new user created (as done in
> config_sspi_auth()). We can do that with pg_regress --create-role and
> PostgresNode.pm::init() can help with that. So the fix is simple
> enough. I'll make sure that it works properly at the beginning of
> next week. For now the patch is reverted.
I'm not sure that reverting and re-committing a slightly improved patch
is a better approach than just waiting for the (presumably small) fix to
be committed. Leaving a small number of animals in red for a small
period is not that bad.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-04-13 17:22:41 | pgsql: Prevent memory leaks associated with relcache rd_partcheck struc |
| Previous Message | Noah Misch | 2019-04-13 05:53:57 | pgsql: Consistently test for in-use shared memory. |