Re: pgsql: Switch TAP tests of pg_rewind to use a role with minimal permiss

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Switch TAP tests of pg_rewind to use a role with minimal permiss
Date: 2019-04-13 04:24:04
Message-ID: 20190413042404.GA1753@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Fri, Apr 12, 2019 at 11:54:48PM -0400, Tom Lane wrote:
> Hm. Seems like that test case could also use some work so that it's
> more obvious when it has connection problems.

For the problem reported, the deal is that we need to add in
pg_indent.conf a mapping to the new user created (as done in
config_sspi_auth()). We can do that with pg_regress --create-role and
PostgresNode.pm::init() can help with that. So the fix is simple
enough. I'll make sure that it works properly at the beginning of
next week. For now the patch is reverted.
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2019-04-13 04:24:12 pgsql: Revert "Switch TAP tests of pg_rewind to use a role with minimal
Previous Message Tom Lane 2019-04-13 03:54:48 Re: pgsql: Switch TAP tests of pg_rewind to use a role with minimal permiss