| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Removed unused variable, openLogOff. |
| Date: | 2019-03-08 01:27:52 |
| Message-ID: | 20190308012752.GC4099@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Thu, Mar 07, 2019 at 11:11:16PM +0900, Michael Paquier wrote:
> If you want to keep this formulation, that's fine for me. However you
> should really change it to nleft as you suggest, and not keep nbytes.
After sleeping on it, let's live with just switching to nleft in the
message, without openLogOff as that's the second time folks complain
about the previous code. So I just propose the attached. Robert,
others, any objections? Perhaps you would prefer fixing it yourself?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| xlog-nbytes-fix.patch | text/x-diff | 535 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-03-08 06:12:10 | pgsql: Fix function signatures of pageinspect in documentation |
| Previous Message | Michael Paquier | 2019-03-08 01:18:05 | pgsql: Fix compatibility of pg_basebackup -R with 11 and older versions |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-03-08 01:35:23 | Re: Add exclusive backup deprecation notes to documentation |
| Previous Message | Thomas Munro | 2019-03-08 01:25:48 | Re: patch to allow disable of WAL recycling |