| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Christoph Berg <christoph(dot)berg(at)credativ(dot)de>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well |
| Date: | 2019-01-22 20:19:23 |
| Message-ID: | 20190122201923.3iaz7lxs3ckibzwo@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2019-01-22 17:10:58 -0300, Alvaro Herrera wrote:
> On 2019-Jan-22, Andres Freund wrote:
>
> > I think its plain wrong to add COPT to CXXFLAGS. Re PROFILE I'm on the
> > fence. I personally think the pgxs stuff is a bit separate, and I'm
> > doubtful we ought to backpatch that. I'm basically planning to apply
> > https://www.postgresql.org/message-id/20190107091734.GA1582%40msg.credativ.de
> > to 11-, minus the PGXS stuff. If we want that, we ought to apply it to
> > master only IMO.
>
> I don't understand why you don't want to backpatch the PGXS bits.
Largely because I think it's an independent patch from the CXXOPT need
from Christopher / Debian packaging. It's a larger patch, that needs
more docs etc. If whoever applies that wants to backpatch it - I'm not
going to protest, I just wouldn't myself, unless somebody pipes up that
it'd help them.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2019-01-22 20:29:23 | Re: Refactoring the checkpointer's fsync request queue |
| Previous Message | Alvaro Herrera | 2019-01-22 20:10:58 | Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well |