Re: pgsql: Remove function names from error messages

On 2018-Dec-20, Michael Paquier wrote:

> On Wed, Dec 19, 2018 at 05:53:48PM +0000, Alvaro Herrera wrote:
> > Remove function names from error messages
> >
> > They are not necessary, and having them there gives useless work for
> > translators.
>
> I am spotting a couple of extra ones for functions:
> src/backend/access/transam/xlog.c:
> (errmsg("pg_stop_backup cleanup done, waiting for required WAL segments
> to be archived")));

Yeah, I grepped for other uses and found format() being mentioned too,
but there didn't seem to be any repetition in the messages other than
the ones I patched, so I didn't bother. Thanks for following through
with these ones in the other thread.

I grepped using '()' as part of the pattern to find function names;
maybe there's a more comprehensive way.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services