Re: pgsql: Remove function names from error messages

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Remove function names from error messages
Date: 2018-12-19 23:41:03
Message-ID: 20181219234103.GC27104@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Wed, Dec 19, 2018 at 05:53:48PM +0000, Alvaro Herrera wrote:
> Remove function names from error messages
>
> They are not necessary, and having them there gives useless work for
> translators.

I am spotting a couple of extra ones for functions:
src/backend/access/transam/xlog.c:
(errmsg("pg_stop_backup cleanup done, waiting for required WAL segments
to be archived")));

src/backend/access/transam/xlog.c:
(errmsg("pg_stop_backup still waiting for all required WAL segments to
be archived (%d seconds elapsed)",

Perhaps these could be improved as well?
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-12-20 00:42:31 Re: pgsql: Remove function names from error messages
Previous Message Tom Lane 2018-12-19 22:46:34 pgsql: Add text-vs-name cross-type operators, and unify name_ops with t