From: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
---|---|
To: | michael(at)paquier(dot)xyz |
Cc: | amit(dot)kapila16(at)gmail(dot)com, robertmhaas(at)gmail(dot)com, hlinnaka(at)iki(dot)fi, dilipbalaut(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Problem while setting the fpw with SIGHUP |
Date: | 2018-09-18 04:06:09 |
Message-ID: | 20180918.130609.114824861.horiguchi.kyotaro@lab.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello.
At Tue, 18 Sep 2018 11:38:50 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote in <20180918(dot)113850(dot)164570138(dot)horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
> At Thu, 6 Sep 2018 16:37:28 -0700, Michael Paquier <michael(at)paquier(dot)xyz> wrote in <20180906233728(dot)GR2726(at)paquier(dot)xyz>
> > I am finally coming back to this patch set, and that's one of the first
> > things I am going to help moving on for this CF. And this bit from the
> > last patch series is not acceptable as there are some parameters which
> > are used by the startup process which can be reloaded. One of them is
> > wal_retrieve_retry_interval for tuning when fetching WAL at recovery.
>
> The third patch actually is not mandatory in the patch set. The
> only motive of that is it doesn't nothing. The handler for SIGHUP
> just sets got_SIGHUP then wakes up the process, and the variable
> is not looked up by no one. If you mind the change, it can be
> removed with no side effect.
I was wrong here. It was handled in HandleStartupProcInterrupts
called from StartupXLOG. So, it should be just removed from the
set. Sorry for the bogus patch.
--
Kyotaro Horiguchi
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Khandekar | 2018-09-18 04:33:02 | Re: Query is over 2x slower with jit=on |
Previous Message | Pavel Stehule | 2018-09-18 04:01:19 | Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11) |