From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Clean up after TAP tests in oid2name and vacuumlo. |
Date: | 2018-09-05 18:20:03 |
Message-ID: | 20180905182003.7sdaha3m7w5pgus5@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On 2018-Sep-05, Michael Paquier wrote:
> On Wed, Sep 05, 2018 at 11:39:50AM -0300, Alvaro Herrera wrote:
> > Should this be used in src/test/modules/{brin,test_commit_ts} also?
>
> Hmm, I have not thought those two ones. commit_ts relies on REGRESS to
> be defined so as it does its cleanup. brin is more interesting, it
> directly quotes that it needs to tweak its Makefile to do the cleanup,
> and it uses isolation tests. Wouldn't it be more adapted to add a
> second extra switch for isolation tests similar to REGRESS? We could
> call it ISOLATION, and it would list the set of isolation tests you
> could run from an extension. That would be useful for a lot of folks.
>
> Thoughts?
Yeah, +1 for that.
> It would be better to start a new thread rather than posting
> a new patch, but I'd rather take the temperature first.
Slightly feverish, it appears.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-09-05 18:30:04 | pgsql: Remove no-longer-used variable. |
Previous Message | Tom Lane | 2018-09-05 17:49:34 | Re: pgsql: Clean up after TAP tests in oid2name and vacuumlo. |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2018-09-05 18:28:13 | Re: pg_verify_checksums failure with hash indexes |
Previous Message | Marina Polyakova | 2018-09-05 18:19:38 | Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors |