| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Clean up after TAP tests in oid2name and vacuumlo. |
| Date: | 2018-09-05 17:45:27 |
| Message-ID: | 20180905174527.GA2726@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, Sep 05, 2018 at 11:39:50AM -0300, Alvaro Herrera wrote:
> Should this be used in src/test/modules/{brin,test_commit_ts} also?
Hmm, I have not thought those two ones. commit_ts relies on REGRESS to
be defined so as it does its cleanup. brin is more interesting, it
directly quotes that it needs to tweak its Makefile to do the cleanup,
and it uses isolation tests. Wouldn't it be more adapted to add a
second extra switch for isolation tests similar to REGRESS? We could
call it ISOLATION, and it would list the set of isolation tests you
could run from an extension. That would be useful for a lot of folks.
Thoughts? It would be better to start a new thread rather than posting
a new patch, but I'd rather take the temperature first.
> Why do you guys design Makefile rules in pgsql-committers?
That was a bad idea, and a reaction to what Tom has committed for the
cleanup of the new TAP tests I have added previously.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-09-05 17:47:55 | pgsql: Make argument names of pg_get_object_address consistent, and fix |
| Previous Message | Alvaro Herrera | 2018-09-05 17:36:59 | pgsql: Simplify partitioned table creation vs. relcache |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-09-05 17:49:34 | Re: pgsql: Clean up after TAP tests in oid2name and vacuumlo. |
| Previous Message | Masahiko Sawada | 2018-09-05 17:23:06 | Re: Bug in ginRedoRecompress that causes opaque data on page to be overrun |