Re: Enhancing protocol.sgml

From: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
To: bpd0018(at)gmail(dot)com
Cc: pgsql-docs(at)postgresql(dot)org
Subject: Re: Enhancing protocol.sgml
Date: 2018-08-25 22:05:51
Message-ID: 20180826.070551.1769438420290125254.t-ishii@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

Hi Bradley,

Thank your for your follow up. Your patch looks good to me.

Can you please re-send your message in pgsql-hackers attaching to this thread?
https://www.postgresql.org/message-id/flat/20180730(dot)080748(dot)1152436144966943439(dot)t-ishii(at)sraoss(dot)co(dot)jp

I have registered the thread in CommitFest:
https://commitfest.postgresql.org/19/1738/

Unfortunately CommitFest app does not allow to handle emails other
than posted to pgsql-hackers. So I decided to post to pgsql-hackers
after posting to pgsql-docs.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

From: "Bradley DeJong" <bpd0018(at)gmail(dot)com>
Subject: Re: Enhancing protocol.sgml
Date: Fri, 24 Aug 2018 15:43:28 +0000
Message-ID: <embf269241-6c21-44d2-8c0e-629656d3b112(at)dolphin>

> On 2018-07-27, Tatsuo Ishii wrote ...
>> ... I think this should be mentioned in protocol.sgml as well. ...
>
> I agree. It is already mentioned as one of the differences between v2
> and v3 but an implementer should not need to read that section if they
> are only implementing v3. (I know I've never looked at it before.)
>
> Using protocol.diff as a base, I changed the phrasing to be more
> prescriptive for v3 protocol implementers (don't send a final line, be
> prepared to receive a final line), changed passive voice to active
> voice and fixed one COPYData -> CopyData capitalization.
>
> I also called this out in the description of the CopyData message
> format because that is where the termination line would be
> transmitted.

In response to

Browse pgsql-docs by date

  From Date Subject
Next Message KES 2018-08-26 09:08:15 Re: Documentation does not cover multiple WITH in one query
Previous Message Bruce Momjian 2018-08-25 19:04:43 Re: Misc typos in documentation