| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, nospam-abuse(at)bloodgate(dot)com, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, David Steele <david(at)pgmasters(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Marko Tiikkaja <marko(at)joh(dot)to>, Jim Nasby <jim(dot)nasby(at)bluetreble(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] plpgsql - additional extra checks |
| Date: | 2018-07-09 20:01:11 |
| Message-ID: | 20180709200111.snge7xqgc4vewan4@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018-Jul-09, Andres Freund wrote:
> On 2018-07-09 15:44:36 -0400, Alvaro Herrera wrote:
> > > + ereport(errlevel,
> > > (errcode(ERRCODE_TOO_MANY_ROWS),
> > > errmsg("query returned more than one row"),
> > > - errdetail ? errdetail_internal("parameters: %s", errdetail) : 0));
> > > + errdetail ? errdetail_internal("parameters: %s", errdetail) : 0,
> > > + use_errhint ? errhint("too_many_rows check of extra_%s is active.",
> > > + too_many_rows_level == ERROR ? "errors" : "warnings") : 0));
> >
> > Please write this in a way that results in less translatable messages,
> > and don't build setting names at runtime. Concretely I suggest this:
> >
> > errhint(too_many_rows_level == ERROR ?
> > gettext_noop("%s check of extra_errors is active.") :
> > gettext_noop("%s check of extra_warnings is active."),
> > "too_many_rows");
>
> Why not put extra_errors/extra_warnings into a variable as well?
Yeah, what he said. (Then you *really* need a /* translator: */ comment
to explain.)
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2018-07-09 20:10:27 | Re: Un peu décu : Re: Performance regression with PostgreSQL 11 and partitioning |
| Previous Message | David Rowley | 2018-07-09 19:58:58 | Re: Generating partitioning tuple conversion maps faster |