Re: Fix slot's xmin advancement and subxact's lost snapshots in decoding.

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Arseny Sher <a(dot)sher(at)postgrespro(dot)ru>
Cc: Antonin Houska <ah(at)cybertec(dot)at>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Petr Jelinek <petr(at)2ndquadrant(dot)com>
Subject: Re: Fix slot's xmin advancement and subxact's lost snapshots in decoding.
Date: 2018-06-26 20:52:48
Message-ID: 20180626205248.37fz6uqu3o4ksy7h@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Pushed this to 9.4 - master after some more tinkering.

It occurred to me that it might be better to have
ReorderBufferSetBaseSnapshot do the IncrRefCount instead of expecting
caller to do it. But I wouldn't backpatch that change, so I refrained.

Thanks for the patch.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robbie Harwood 2018-06-26 20:54:13 Re: [HACKERS] [PATCH] WIP Add ALWAYS DEFERRED option for constraints
Previous Message Alvaro Herrera 2018-06-26 20:50:03 pgsql: Fix "base" snapshot handling in logical decoding