Re: Time to put context diffs in the grave

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Time to put context diffs in the grave
Date: 2018-06-19 21:42:50
Message-ID: 20180619214250.zntarfgywsmscjrr@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2018-06-19 17:41:00 -0400, Tom Lane wrote:
> Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
> > On 06/19/2018 05:21 PM, Andres Freund wrote:
> >> Given that we've "officially" stopped relying on context diffs,
> >> I don't see why we'd not also retire them in pg_regress.
>
> > Well I suspect at least one person would be made unhappy ;-)
>
> Not requiring them is considerably different from actually trying
> to stamp them out.

Sure - but I'm not trying to get rid of PG_REGRESS_DIFF_OPTS, just
talking about changing the defaults.

> There's already a (perhaps underdocumented) way to make regression
> diffs look the way you want in local runs. Andrew's idea of getting
> the buildfarm server to display diffs either way would go a long
> way towards having that same flexibility for buildfarm results, though
> it does seem like rather a lot of work for a small point :-(

Yea, if this were all already available, I'd be happy with it. But...

Greetings,

Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2018-06-19 21:45:05 Re: Time to put context diffs in the grave
Previous Message Tom Lane 2018-06-19 21:41:00 Re: Time to put context diffs in the grave