Re: Time to put context diffs in the grave

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Time to put context diffs in the grave
Date: 2018-06-19 21:41:00
Message-ID: 17690.1529444460@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
> On 06/19/2018 05:21 PM, Andres Freund wrote:
>> Given that we've "officially" stopped relying on context diffs,
>> I don't see why we'd not also retire them in pg_regress.

> Well I suspect at least one person would be made unhappy ;-)

Not requiring them is considerably different from actually trying
to stamp them out. To my mind, where we're trying to go here is
not having one set of people impose their diff format preferences
on other people.

There's already a (perhaps underdocumented) way to make regression
diffs look the way you want in local runs. Andrew's idea of getting
the buildfarm server to display diffs either way would go a long
way towards having that same flexibility for buildfarm results, though
it does seem like rather a lot of work for a small point :-(

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2018-06-19 21:42:50 Re: Time to put context diffs in the grave
Previous Message Bruce Momjian 2018-06-19 21:34:52 Re: PostgreSQL and Homomorphic Encryption