| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, David Steele <david(at)pgmasters(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: perlcritic and perltidy |
| Date: | 2018-05-08 17:02:51 |
| Message-ID: | 20180508170251.jxph6zblonie6f3l@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Stephen Frost wrote:
> * Andrew Dunstan (andrew(dot)dunstan(at)2ndquadrant(dot)com) wrote:
>
> > - 'XLogRecPtr' => 'pg_lsn');
> > + 'XLogRecPtr' => 'pg_lsn',);
>
> There's not much point adding the ',' unless you're also putting the
> ');' on the next line, is there..?
>
> Or is that going to be handled in a follow-up patch?
IMO we should classify this one as pointless uglification and move on.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2018-05-08 17:06:42 | Re: perlcritic and perltidy |
| Previous Message | Jesper Pedersen | 2018-05-08 16:56:46 | Re: [HACKERS] Clock with Adaptive Replacement |