Re: Bogus reports from coverage.postgresql.org

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-www(at)lists(dot)postgresql(dot)org
Subject: Re: Bogus reports from coverage.postgresql.org
Date: 2018-03-10 04:06:27
Message-ID: 20180310040627.nwckurme2w42onp3@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

On 2018-03-09 19:36:28 -0500, Tom Lane wrote:
> I happened to notice that if you look at
> https://coverage.postgresql.org/src/backend/optimizer/util/predtest.c.gcov.html
> it claims that the two occurrences of
> elog(ERROR, "predicate_classify returned a bogus value");
> at lines 492 and 803 are reached.
>
> This would be quite astonishing if true, but it isn't true, since
> the regression tests aren't reporting any such failure.
>
> Needless to say, this puts quite a damper on my faith in the coverage
> reports. Maybe that machine needs a software update?

Is it possible that the compiler figured that the patch is unreachable
and removed the code?

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-www by date

  From Date Subject
Next Message Tom Lane 2018-03-10 04:42:33 Re: Bogus reports from coverage.postgresql.org
Previous Message Tom Lane 2018-03-10 00:36:28 Bogus reports from coverage.postgresql.org