From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | pgsql-www(at)lists(dot)postgresql(dot)org |
Subject: | Re: Bogus reports from coverage.postgresql.org |
Date: | 2018-03-10 04:42:33 |
Message-ID: | 15758.1520656953@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-www |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2018-03-09 19:36:28 -0500, Tom Lane wrote:
>> I happened to notice that if you look at
>> https://coverage.postgresql.org/src/backend/optimizer/util/predtest.c.gcov.html
>> it claims that the two occurrences of
>> elog(ERROR, "predicate_classify returned a bogus value");
>> at lines 492 and 803 are reached.
> Is it possible that the compiler figured that the patch is unreachable
> and removed the code?
Maybe, but then it's even less reasonable to claim that the lines
were reached.
In general, lcov seems to ignore lines for which no code was generated,
which is fine by me.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2018-03-10 17:27:14 | Re: Bogus reports from coverage.postgresql.org |
Previous Message | Andres Freund | 2018-03-10 04:06:27 | Re: Bogus reports from coverage.postgresql.org |