| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Missing comment edit |
| Date: | 2018-03-01 09:31:39 |
| Message-ID: | 20180301093139.hg4h2cjl2bqugz76@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018-02-28 19:03:01 -0500, Tom Lane wrote:
> Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> writes:
> > I happend to find that the comment on formdesc is missing
> > pg_subscription. Please find the attached patch (I'm sure:) to
> > fix that .
>
> Hmm ... certainly, that comment is now wrong, but I'm kind of inclined
> to just remove it, because it'll certainly be wrong again in future.
> It's not telling you anything you can't find out with a trivial search
> in the same file, so is it worth the maintenance overhead?
+1. Do you want to do the honors? If you don't and nobody comments,
I'll do so.
- Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-03-01 09:42:00 | Re: Minor fix for pgbench documentation |
| Previous Message | Andres Freund | 2018-03-01 09:28:23 | Re: [PoC PATCH] Parallel dump to /dev/null |