Re: Missing comment edit

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Missing comment edit
Date: 2018-03-01 00:03:01
Message-ID: 10701.1519862581@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> writes:
> I happend to find that the comment on formdesc is missing
> pg_subscription. Please find the attached patch (I'm sure:) to
> fix that .

Hmm ... certainly, that comment is now wrong, but I'm kind of inclined
to just remove it, because it'll certainly be wrong again in future.
It's not telling you anything you can't find out with a trivial search
in the same file, so is it worth the maintenance overhead?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikita Glukhov 2018-03-01 00:12:38 Re: Cast jsonb to numeric, int, float, bool
Previous Message Euler Taveira 2018-02-28 23:59:42 unused includes in test_decoding