Re: money type's overflow handling is woefully incomplete

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: money type's overflow handling is woefully incomplete
Date: 2017-12-12 21:50:22
Message-ID: 20171212215022.k47fnly4ivsxswne@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2017-12-12 16:47:17 -0500, Tom Lane wrote:
> Really? We've got test cases that intentionally exercise overflow
> in the money code? I think we could just drop such tests, until
> such time as someone fixes the issue.

Some parts at least (input & output), I think it's easy enough to fix
those up.

> (OTOH, I bet we could drop reltime/abstime without too many complaints.
> Y2038 is coming.)

I'm actually about to send a patch doing so, that code is one mess WRT
overflow handling.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-12-12 21:56:01 Re: explain analyze output with parallel workers - question about meaning of information for explain.depesz.com
Previous Message Tom Lane 2017-12-12 21:47:17 Re: money type's overflow handling is woefully incomplete