From: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
---|---|
To: | alvherre(at)alvh(dot)no-ip(dot)org |
Cc: | sawada(dot)mshk(at)gmail(dot)com, robertmhaas(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: show "aggressive" or not in autovacuum logs |
Date: | 2017-10-26 08:18:56 |
Message-ID: | 20171026.171856.28343712.horiguchi.kyotaro@lab.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Thank you for the comment.
(Thank you Sawada-san for reviewng, too.)
At Thu, 19 Oct 2017 13:03:38 +0200, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote in <20171019110338(dot)awwzc3y674co7wof(at)alvherre(dot)pgsql>
> Kyotaro HORIGUCHI wrote:
>
> > How about the followings?
> >
> > "automatic [agressive ]vacuum of table \"%s..."
> > "[aggressive ]vacuuming \"%s..."
>
> That form of log message seems acceptable to me (first one is missing a 'g').
>
> In any case, please do not construct the sentence with %s expanding the
> word, because that is going to cause a problem for translations. Use an
> 'if' test with two full sentences instead. Yes, as Robert said, it's
> going to add more strings, but that's okay.
Thank you. I forgot that point. Changed them so that the messages
are detected as msgids.
regards,
--
Kyotaro Horiguchi
NTT Open Source Software Center
Attachment | Content-Type | Size |
---|---|---|
0001-Show-aggressive-or-not-in-vacuum-messages.patch | text/x-patch | 2.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Meskes | 2017-10-26 08:44:05 | Re: [bug fix] ECPG: fails to recognize embedded parameters |
Previous Message | 高增琦 | 2017-10-26 08:03:50 | Try to fix endless loop in ecpg with informix mode |