| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | sawada(dot)mshk(at)gmail(dot)com, robertmhaas(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: show "aggressive" or not in autovacuum logs |
| Date: | 2017-10-19 11:03:38 |
| Message-ID: | 20171019110338.awwzc3y674co7wof@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Kyotaro HORIGUCHI wrote:
> How about the followings?
>
> "automatic [agressive ]vacuum of table \"%s..."
> "[aggressive ]vacuuming \"%s..."
That form of log message seems acceptable to me (first one is missing a 'g').
In any case, please do not construct the sentence with %s expanding the
word, because that is going to cause a problem for translations. Use an
'if' test with two full sentences instead. Yes, as Robert said, it's
going to add more strings, but that's okay.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sokolov Yura | 2017-10-19 11:36:56 | Re: Fix performance degradation of contended LWLock on NUMA |
| Previous Message | Masahiko Sawada | 2017-10-19 10:05:28 | Fix a typo in libpq/auth.c |