From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
Cc: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: brin_summarize_new_values error checking |
Date: | 2017-09-23 11:16:30 |
Message-ID: | 20170923111630.rrl3uuy6d4hmcopo@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Fujii Masao wrote:
> On Wed, Jan 27, 2016 at 11:56 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> > On Mon, Jan 25, 2016 at 4:03 PM, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
> >> In reviewing one of my patches[1], Fujii-san has pointed out that I
> >> didn't include checks for being in recovery, or for working on another
> >> backend's temporary index.
> >>
> >> I think that brin_summarize_new_values in 9.5.0 commits those same
> >> sins. In its case, I don't think those are critical, as they just
> >> result in getting less specific error messages that one might hope
> >> for, rather than something worse like a panic.
> >>
> >> But still, we might want to address them.
> >
> > Agreed to add those checks.
>
> Attached patch does this.
Uh, I just realized you never applied this patch ... Will you do so now?
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2017-09-23 12:41:25 | Re: [BUGS] BUG #14825: enum type: unsafe use? |
Previous Message | Alvaro Herrera | 2017-09-23 11:14:15 | Re: Rethinking autovacuum.c memory handling |