| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Avoid GatherMerge crash when there are no workers. |
| Date: | 2017-08-14 22:33:57 |
| Message-ID: | 20170814223357.i45ghd3pkcvypacy@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Hi,
On 2017-04-03 12:56:36 +0530, Rushabh Lathia wrote:
> On my local environment I was getting coverage for the heap_compare_slots
> with
> existing test. But it seems like due to low number of record fetch only
> leader get
> evolved to the fetching tuples in the shared report.
>
> I modified the current test coverage for the Gather Merge to add more rows
> to be
> fetch by the GatherMerge node to make sure that it do coverage for
> heap_compare_slots. Also added test for the zero worker.
>
> PFA patch as well as LCOV report for the nodeGatherMerge.c.
Pushed, thanks!
- Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-08-15 03:01:01 | pgsql: pg_dump: Add a --load-via-partition-root option. |
| Previous Message | Andres Freund | 2017-08-14 22:29:29 | pgsql: Expand coverage of parallel gather merge a bit. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2017-08-14 22:35:24 | Re: Crash report for some ICU-52 (debian8) COLLATE and work_mem values |
| Previous Message | Andres Freund | 2017-08-14 22:29:55 | Re: [postgresql 10 beta3] unrecognized node type: 90 |