Re: Notice message of ALTER SUBSCRIPTION ... RERESH PUBLICATIION

From: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Notice message of ALTER SUBSCRIPTION ... RERESH PUBLICATIION
Date: 2017-08-08 03:19:49
Message-ID: 20170808121949.3622a24d.nagata@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 7 Aug 2017 09:46:56 -0400
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:

> On 7/27/17 20:51, Yugo Nagata wrote:
> > When we run ALTER SUBSCRIPTION ... REFRESH PUBLICATION and there is
> > an unkown table at local, it says;
> >
> > NOTICE: added subscription for table public.tbl
> >
> > I feel this a bit misleading because it says a subscription is added
> > but actually new subscription object is not created. Of cause, I can
> > understand the intention this message says, but I feel that
> > it is better to use other expression. For example, how about saying
> >
> > NOTICE: table public.tbl is added to subscription sub1
> >
> > as proposed in the attached patch. This also fixes the message
> > when a table is removed from a subscription.
>
> Fixed, thanks. (Note that per another discussion, these are now DEBUG
> messages.)

Thanks, too.

>
> --
> Peter Eisentraut http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2017-08-08 04:21:12 Re: Pluggable storage
Previous Message Amit Langote 2017-08-08 01:11:22 Re: expanding inheritance in partition bound order