| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Assert that we don't invent relfilenodes or type OIDs in binary |
| Date: | 2017-06-13 19:32:03 |
| Message-ID: | 20170613193203.GR13873@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Tue, Jun 13, 2017 at 03:10:16PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > On Tue, Jun 13, 2017 at 11:52:04AM -0700, Andres Freund wrote:
> >> I'm not sure what you're actually concerned about here?
>
> > I am concerned a non-assert build will not error out, but if no one else
> > is concerned about that, I am fine.
>
> I think in a production situation, we actually don't want it to error
> out. The odds are fairly good that the run would complete successfully
> (ie, the potential OID collision never actually materializes). So all
> we're doing is converting a possible failure into an unavoidable one.
>
> Where we want to hear about the problem is in development. So really
> an Assert is the right thing.
OK, but my point is that all the other places, which seems similar,
error out in production.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-06-13 20:11:54 | pgsql: doc: Update example version numbers in pg_upgrade documentation |
| Previous Message | Tom Lane | 2017-06-13 19:10:16 | Re: pgsql: Assert that we don't invent relfilenodes or type OIDs in binary |