Re: Backup taking long time !!!

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>
Cc: Vladimir Borodin <root(at)simply(dot)name>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Dinesh Chandra 12108 <Dinesh(dot)Chandra(at)cyient(dot)com>, "Madusudanan(dot)B(dot)N" <b(dot)n(dot)madusudanan(at)gmail(dot)com>, "pgsql-performance(at)postgresql(dot)org" <pgsql-performance(at)postgresql(dot)org>, David Steele <david(at)pgmasters(dot)net>
Subject: Re: Backup taking long time !!!
Date: 2017-01-23 15:27:22
Message-ID: 20170123152722.GX18360@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-performance

* Jim Nasby (Jim(dot)Nasby(at)BlueTreble(dot)com) wrote:
> On 1/20/17 9:06 AM, Stephen Frost wrote:
> >All the pages are the same size, so I'm surprised you didn't consider
> >just having a format along the lines of: magic+offset+page,
> >magic+offset+page, magic+offset+page, etc...
>
> Keep in mind that if you go that route you need to accommodate BLKSZ
> <> 8192.

If you want my 2c on that, running with BLKSZ <> 8192 is playing with
fire, or at least running with scissors.

That said, yes, the code should either barf when BLKSZ <> 8192 in a very
clear way early on, or handle it correctly, and be tested with such
configurations.

Thanks!

Stephen

In response to

Responses

Browse pgsql-performance by date

  From Date Subject
Next Message Jim Nasby 2017-01-23 15:28:34 Re: Backup taking long time !!!
Previous Message Jim Nasby 2017-01-23 15:16:38 Re: Backup taking long time !!!