| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: make more use of RoleSpec struct |
| Date: | 2016-12-28 15:33:56 |
| Message-ID: | 20161228153356.hmkxhuhzjepilzeo@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Stephen Frost wrote:
> * Alvaro Herrera (alvherre(at)2ndquadrant(dot)com) wrote:
> > The only functional issue might be the removal of the IsA() checks. If
> > we don't cast any Node before passing it to any of those functions,
> > there should be no problem because any misfeasance will be reported as a
> > compile-time warning. Perhaps it's worth adding IsA() checks in loops
> > such as the one in roleSpecsToIds().
>
> Maybe inside of an Assert() though..?
Yeah, I was of two minds when writing that para. Maybe roleSpecsToIds
(and all similar functions, if any others exist) has a limited enough
caller base that it's trivial to audit that no bogus callsite exists.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2016-12-28 15:35:09 | Re: Reporting planning time with EXPLAIN |
| Previous Message | Tom Lane | 2016-12-28 15:29:48 | Re: Reporting planning time with EXPLAIN |