Re: pgsql: Make pg_dumpall's database ACL query independent of hash table o

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Make pg_dumpall's database ACL query independent of hash table o
Date: 2016-10-13 21:14:42
Message-ID: 20161013211442.sundozmvxcwrbc6c@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2016-10-13 09:41:38 -0700, Andres Freund wrote:
> On 2016-10-13 10:49:14 -0400, Tom Lane wrote:
> > Andres Freund <andres(at)anarazel(dot)de> writes:
> > > On 2016-10-13 01:33:53 +0000, Andres Freund wrote:
> > >> Make pg_dumpall's database ACL query independent of hash table order.
> >
> > > Hrmpf, longfin doesn't like this much (as in unstable order).
> >
> > It was failing for me and Peter as well. Did you generate the new
> > test in a non-C locale environment?
>
> Well, it's not a new test, just an existing one that was dependant on
> hash order. But yes, I did check the output on en_US. I guess slapping a
> collate C on it would work. Brr, this test isn't pretty, and hard to
> debug.

Thanks for pushing something to fix this up. Was about to do the same ;)

Andres

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tatsuo Ishii 2016-10-13 22:41:31 Re: [COMMITTERS] pgsql: Remove spurious word.
Previous Message Tom Lane 2016-10-13 21:05:39 pgsql: Fix another bug in merging of inherited CHECK constraints.