Re: pgsql: Make pg_dumpall's database ACL query independent of hash table o

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Make pg_dumpall's database ACL query independent of hash table o
Date: 2016-10-13 16:41:38
Message-ID: 20161013164138.2ad7pu6sgipieoow@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2016-10-13 10:49:14 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > On 2016-10-13 01:33:53 +0000, Andres Freund wrote:
> >> Make pg_dumpall's database ACL query independent of hash table order.
>
> > Hrmpf, longfin doesn't like this much (as in unstable order).
>
> It was failing for me and Peter as well. Did you generate the new
> test in a non-C locale environment?

Well, it's not a new test, just an existing one that was dependant on
hash order. But yes, I did check the output on en_US. I guess slapping a
collate C on it would work. Brr, this test isn't pretty, and hard to
debug.

Andres

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-10-13 18:00:14 pgsql: Clean up handling of anonymous mmap'd shared-memory segment.
Previous Message Tom Lane 2016-10-13 14:49:14 Re: pgsql: Make pg_dumpall's database ACL query independent of hash table o