| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Address portability issues in bfe16d1a5 test output. |
| Date: | 2016-09-13 01:32:13 |
| Message-ID: | 20160913013213.uwy54i522l4lrfwl@alap3.anarazel.de |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 2016-09-12 21:25:05 -0400, Tom Lane wrote:
> Hm, lapwing says this can't run in parallel with "misc" either :-(
Gah. That's probably why I had originally had it running in the rules
group. But isn't that user_relns() test just a bad idea independent of
this failure? I mean what's the benefit of returning all relations
there, besides causing regression test churn? If you look at a git
blame you can see that there's quite a bit of changes in those few lines
of expected output.
> I'm not sure about the change you made to have generate_series output
> just one row --- isn't that losing some of the point of the test?
For me the test was mostly verifying that the pushdown logic does
something sensible, namely that the aggrefs are at the right level.
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-09-13 01:33:03 | Re: pgsql: Address portability issues in bfe16d1a5 test output. |
| Previous Message | Tom Lane | 2016-09-13 01:25:05 | Re: pgsql: Address portability issues in bfe16d1a5 test output. |