Re: PostmasterPid not marked with PGDLLIMPORT

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Craig Ringer <craig(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PostmasterPid not marked with PGDLLIMPORT
Date: 2016-06-01 16:24:12
Message-ID: 20160601162412.GA44212@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas wrote:
> On Wed, Jun 1, 2016 at 12:06 AM, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
> > On 1 June 2016 at 11:48, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:
> >> Could it be possible to mark PostmasterPid with PGDLLIMPORT on HEAD
> >> and back-branches?
> >
> > Sounds sensible to me.
>
> I don't really want to set a precedent that we'll back-patch
> PGDLLIMPORT markings every time somebody needs a new symbol for some
> extension they are writing, but I don't mind changing this in master.

I wonder why is that -- just to reduce the commit load? I don't think
this kind of change is likely to break anything, is it?

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2016-06-01 17:13:49 Re: JSON[B] arrays are second-class citizens
Previous Message David G. Johnston 2016-06-01 16:17:51 Re: JSON[B] arrays are second-class citizens