Re: Timeline following for logical slots

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Craig Ringer <craig(at)2ndquadrant(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Timeline following for logical slots
Date: 2016-05-02 19:47:49
Message-ID: 20160502194749.GA30397@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund wrote:

> - /* oldest LSN that the client has acked receipt for */
> + /*
> + * Oldest LSN that the client has acked receipt for. This is used as the
> + * start_lsn point in case the client doesn't specify one, and also as a
> + * safety measure to back off in case the client specifies a start_lsn
> + * that's further in the future than this value.
> + */
> XLogRecPtr confirmed_flush;
>
> This is the wrong way round. confirmed_flush is used if the client's
> start_lsn is further in the *past* than this value.

Bah. Funnily enough I got this one right in the comment for
CreateDecodingContext.

Thanks for reading through the commit.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2016-05-02 19:49:11 Re: Rename max_parallel_degree?
Previous Message Robert Haas 2016-05-02 19:22:52 Re: Rename max_parallel_degree?