Re: pg_upgrade 9.6->9.6: column "amtype" does not exist

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Christoph Berg <myon(at)debian(dot)org>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_upgrade 9.6->9.6: column "amtype" does not exist
Date: 2016-04-29 01:32:39
Message-ID: 20160429013239.GD11728@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Apr 1, 2016 at 05:55:58PM -0400, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > The reason for the failure is that pg_dump knows that 9.6 installations
> > have the amtype column -- but on your older devel 9.6 install, it
> > doesn't exist. To fix it we would have to compare catalog versions in
> > pg_dump rather than major version, but we don't that anywhere. Anyway
> > many upgrades could fail depending on other patches because of the same
> > reason. I don't think we need to fix this.
>
> We've never expected pg_dump to be able to handle intermediate development
> versions. It's enough of a maintenance burden that it knows how to dump
> from all previous stable branches.

Pg_upgrade does handle catalog version changes. I don't think we ever
anticipated catalog changes that would throw errors in pg_dump, which
pg_upgrade relies on. I am saying that someday we might need pg_dump to
track catalog versions. However, I am not even sure how pg_dump would
check the catalog version.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-04-29 02:06:27 Re: [sqlsmith] Crash in apply_projection_to_path
Previous Message Bruce Momjian 2016-04-28 23:40:14 Re: pg_xlog -> pg_xjournal?