Re: Breakage with VACUUM ANALYSE + partitions

From: Noah Misch <noah(at)leadboat(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Thom Brown <thom(at)linux(dot)com>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Breakage with VACUUM ANALYSE + partitions
Date: 2016-04-16 22:53:16
Message-ID: 20160416225316.GA1912870@tornado.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Sat, Apr 16, 2016 at 03:28:23PM -0700, Andres Freund wrote:
> On 2016-04-16 18:23:01 -0400, Noah Misch wrote:
> > On Tue, Apr 12, 2016 at 09:00:57AM -0400, Robert Haas wrote:
> > > On Mon, Apr 11, 2016 at 1:17 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> > > > I can think of a number of relatively easy ways to address this:
> > > > 1) Just zap (or issue?) all pending flush requests when getting an
> > > > smgrinval/smgrclosenode
> > > > 2) Do 1), but filter for the closed relnode
> > > > 3) Actually handle the case of the last open segment not being
> > > > RELSEG_SIZE properly in _mdfd_getseg() - mdnblocks() does so.
> > > >
> > > > I'm kind of inclined to do both 3) and 1).
> >
> > Andres, you own the underlying open item, right?
>
> Right.
>
> > Do you plan to implement this fix you have outlined? If so, when?
>
> Yes, I plan to next week.

Completion by the end of next week will work. Thanks. At that time
(2016-04-24T00:00 UTC), this would otherwise have spent twenty-three days as
an open item. Would you inform this thread if you discover reasons to think
your plan will no longer succeed?

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message yoonghm 2016-04-18 08:48:16 BUG #14095: Make uninstall does not delete some files
Previous Message Andres Freund 2016-04-16 22:28:23 Re: Breakage with VACUUM ANALYSE + partitions

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-04-17 01:02:39 Re: Spinlocks and semaphores in 9.2 and 9.3
Previous Message Andres Freund 2016-04-16 22:39:31 Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold <