Re: pgsql: Improve internationalization of messages involving type names

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Improve internationalization of messages involving type names
Date: 2016-03-28 17:35:58
Message-ID: 20160328173558.GU3127@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Alvaro,

* Alvaro Herrera (alvherre(at)alvh(dot)no-ip(dot)org) wrote:
> Improve internationalization of messages involving type names
>
> Change the slightly different variations of the message
> function FOO must return type BAR
> to a single wording, removing the variability in type name so that they
> all create a single translation entry; since the type name is not to be
> translated, there's no point in it being part of the message anyway.
>
> Also, change them all to use the same quoting convention, namely that
> the function name is not to be quoted but the type name is. (I'm not
> quite sure why this is so, but it's the clear majority.)
>
> Some similar messages such as "encoding conversion function FOO must ..."
> are also changed.

Buildfarm is pretty upset with this one, in particular:

http://git.postgresql.org/gitweb/?p=postgresql.git;a=blobdiff;f=src/backend/commands/event_trigger.c;h=3735d44ee9d0b89f35ca8e8fb00b1a8dbbaa6362;hp=3f52ad836b4a2be1d95047f0949607d8cbbb283d;hb=59a2111;hpb=559e7a0a6d4450c09825055e3d255d30ee869c67

Thanks!

Stephen

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2016-03-28 17:38:02 pgsql: pg_rewind: Improve internationalization
Previous Message Alvaro Herrera 2016-03-28 17:29:02 pgsql: Fix minor leak in pg_dump for ACCESS METHOD.

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2016-03-28 17:45:22 Re: Some messages of pg_rewind --debug not getting translated
Previous Message Claudio Freire 2016-03-28 17:28:22 Re: [WIP] Effective storage of duplicates in B-tree index.