Re: [HACKERS] pg_dump not in very good shape

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] pg_dump not in very good shape
Date: 2000-01-17 06:56:54
Message-ID: 20156.948092214@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Actually the megatest is:

> pg_dump regress > out
> dropdb regression
> createdb regression
> psql regression < out
> pg_dump regress > out2
> diff out out2

> That is the pg_dump test, and someone usually does it as part of
> regression testing before each release.

> It would be nice to add this to test/regress/Makefile maybe.

That's a good thought --- it eliminates both the platform-specific
issues and the problem of adding a bulky reference file to the
distribution.

I'd suggest, though, that the test *not* clobber the regression DB.
Instead

pg_dump regression >out
createdb regression2
psql regression2 <out
pg_dump regression >out2
dropdb regression2 -- maybe
diff out out2

This leaves you a better chance of investigating the diff if you
get one.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2000-01-17 07:12:48 Re: [HACKERS] RE: Getting rid of setheapoverride (was Re: [COMMITTERS] heap.c)
Previous Message Tom Lane 2000-01-17 06:41:28 Re: [HACKERS] flex