Re: [HACKERS] pg_dump not in very good shape

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] pg_dump not in very good shape
Date: 2000-01-17 06:19:19
Message-ID: 200001170619.BAA13413@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

[Charset ISO-8859-1 unsupported, filtering to ASCII...]
> On 2000-01-15, Tom Lane mentioned:
>
> > I have repaired the most recently introduced coredump in pg_dump,
> > but it still crashes on the regression test database.
>
> Which brings up the idea why the regression tests don't test pg_dump. It's
> just as important to people as the backend. psql already gets tested more
> or less. Would it not be a decent idea to do a
>
> pg_dump regress > out
> diff out expected.out
>
> at the end of the tests? That way we could catch these problems
> earlier. (Especially since I'm not sure how many people use pg_dump at all
> during development.)

Actually the megatest is:

pg_dump regress > out
dropdb regression
createdb regression
psql regression < out
pg_dump regress > out2
diff out out2

That is the pg_dump test, and someone usually does it as part of
regression testing before each release.

It would be nice to add this to test/regress/Makefile maybe.

--
Bruce Momjian | http://www.op.net/~candle
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2000-01-17 06:29:16 Re: [HACKERS] pg_dump not in very good shape
Previous Message Bruce Momjian 2000-01-17 06:15:25 Re: [HACKERS] Temp Table Memory Leak