| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, manu(at)coopapotheken(dot)be, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: Re: BUG #13774: upgrade from 9.1 to 9.4 'succeeds' without enough disk space |
| Date: | 2015-11-18 14:42:35 |
| Message-ID: | 20151118144235.GB18047@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Wed, Nov 18, 2015 at 09:30:45AM -0500, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Very good points. The attached patch fixes the copy parameter and
> > addresses the errno issue by just using errno direcdtly after the
> > _dosmaperr call.
>
> You did not change the comment
>
> * Returns the text of the error message for the given error number
>
> even though no error number is a "given" parameter anymore. Maybe
> "... for the most-recently-reported error"?
Good point. I have changed it to "Returns the text of the most recent
error".
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Roman grave inscription +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sandeep Thakkar | 2015-11-19 07:01:46 | Re: BUG #13692: Error when run silent installation whith alredy installed PG9.4 |
| Previous Message | Tom Lane | 2015-11-18 14:30:45 | Re: Re: BUG #13774: upgrade from 9.1 to 9.4 'succeeds' without enough disk space |