Re: Re: BUG #13774: upgrade from 9.1 to 9.4 'succeeds' without enough disk space

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Noah Misch <noah(at)leadboat(dot)com>, manu(at)coopapotheken(dot)be, pgsql-bugs(at)postgresql(dot)org
Subject: Re: Re: BUG #13774: upgrade from 9.1 to 9.4 'succeeds' without enough disk space
Date: 2015-11-18 14:30:45
Message-ID: 11911.1447857045@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Very good points. The attached patch fixes the copy parameter and
> addresses the errno issue by just using errno direcdtly after the
> _dosmaperr call.

You did not change the comment

* Returns the text of the error message for the given error number

even though no error number is a "given" parameter anymore. Maybe
"... for the most-recently-reported error"?

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Bruce Momjian 2015-11-18 14:42:35 Re: Re: BUG #13774: upgrade from 9.1 to 9.4 'succeeds' without enough disk space
Previous Message Bruce Momjian 2015-11-18 13:49:45 Re: BUG #13774: upgrade from 9.1 to 9.4 'succeeds' without enough disk space