| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: AcquireRewriteLocks/acquireLocksOnSubLinks vs. rowsecurity |
| Date: | 2015-08-28 15:41:04 |
| Message-ID: | 20150828154104.GK3685@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
* Andres Freund (andres(at)anarazel(dot)de) wrote:
> On 2015-08-28 08:49:24 -0400, Stephen Frost wrote:
> >
> > + /*
> > + * get_row_security_policies just added to securityQuals and/or
> > + * withCheckOptions, and there were SubLinks, so make sure
> > + * we lock any relations which were added as a result.
> > + */
>
> Very minor comment: Strictly speaking the quals/wces haven't yet been
> added to the Query, that happens only few lines down. I think it makes
> sense to mention that we normally rely on the parser to acquire locks,
> but that can't work here since sec quals/wces aren't visible to the
> parser.
Pushed.
Will work on the rewriteTargetView fix.
Thanks!
Stephen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Teodor Sigaev | 2015-08-28 16:10:05 | Re: Proposal: Implement failover on libpq connect level. |
| Previous Message | Andres Freund | 2015-08-28 15:39:26 | Re: WIP: About CMake v2 |