Re: Run pgindent now?

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Run pgindent now?
Date: 2015-05-25 18:58:26
Message-ID: 20150525185826.GG3908@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, May 25, 2015 at 01:10:04PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Here is a re-run of pgindent on 9.4:
> > http://momjian.us/expire/pgindent-9.4.diff
>
> Some of those diffs would disappear if you'd used an up-to-date typedefs
> list ... not a lot, but some.

Uh, you mean a current 9.4.X typedef list? Should I try that?

> That is rather a lot of diffs, but the thing I think people ought to take
> away from that is "this is the number of back-patch hazards we just
> introduced between HEAD and 9.4" --- because as of yesterday, HEAD looks
> like this not like what's in 9.4. What's more, those hazards are in code
> hunks that were back-patched bug fixes, which means that they are in areas
> that are more likely than average to need additional fixing.

Yes, that is very true.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2015-05-25 19:00:25 Re: Run pgindent now?
Previous Message Bruce Momjian 2015-05-25 18:57:10 Re: Run pgindent now?