| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Christoph Berg <myon(at)debian(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: fsync-pgdata-on-recovery tries to write to more files than previously |
| Date: | 2015-05-25 18:23:02 |
| Message-ID: | 20150525182302.GS26667@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
* Andres Freund (andres(at)anarazel(dot)de) wrote:
> On 2015-05-25 14:14:10 -0400, Stephen Frost wrote:
> > That seems overly complicated, for my 2c at least. I don't particularly
> > like trying to mess with files that might be rightfully considered "not
> > ours" either.
>
> I'd not consider an fsync to be "messing" with files, especially if
> they're in PGDATA.
I'm not entirely sure I agree.
> > > Additionally we could attempt to fsync with a readonly fd before trying
> > > the read-write fd...
> >
> > Not really sure I see that as helping.
>
> On most OSs, except windows and some obscure unixes, a readonly fd is
> allowed to fsync a file.
I wouldn't have thought otherwise, given that you were suggesting it,
but there's no guarantee we're going to be allowed to read it either, or
even access the directory the symlink points to, etc..
Thanks,
Stephen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2015-05-25 18:25:54 | Re: Run pgindent now? |
| Previous Message | Tom Lane | 2015-05-25 18:22:01 | Re: Run pgindent now? |