Re: fsync-pgdata-on-recovery tries to write to more files than previously

From: Andres Freund <andres(at)anarazel(dot)de>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Christoph Berg <myon(at)debian(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: fsync-pgdata-on-recovery tries to write to more files than previously
Date: 2015-05-25 18:17:04
Message-ID: 20150525181704.GM32396@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2015-05-25 14:14:10 -0400, Stephen Frost wrote:
> That seems overly complicated, for my 2c at least. I don't particularly
> like trying to mess with files that might be rightfully considered "not
> ours" either.

I'd not consider an fsync to be "messing" with files, especially if
they're in PGDATA.

> > Additionally we could attempt to fsync with a readonly fd before trying
> > the read-write fd...
>
> Not really sure I see that as helping.

On most OSs, except windows and some obscure unixes, a readonly fd is
allowed to fsync a file.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-05-25 18:20:43 Re: fsync-pgdata-on-recovery tries to write to more files than previously
Previous Message Tom Lane 2015-05-25 18:15:24 Re: Missing importing option of postgres_fdw